Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight outside modified file buffers #1742

Closed
wants to merge 1 commit into from

Conversation

iquiw
Copy link
Contributor

@iquiw iquiw commented Sep 4, 2018

with 'ivy-outside-modified-buffer face.

Fixes #1740

image

EDIT: I don't have copyright assignment, but I think the change is small.

with 'ivy-outside-modified-buffer face.
@manuel-uberti
Copy link
Contributor

@manuel-uberti manuel-uberti commented Sep 4, 2018

I think if it's more than 10 lines of code, you need a CA.

@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Sep 4, 2018

FWIW, the number I've seen is ~15 LOC, but I'm AFK so I can't back that up.

@iquiw
Copy link
Contributor Author

@iquiw iquiw commented Sep 5, 2018

I thought it was 20 lines.
I just saw the following, which says 15 lines.
https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html#Legally-Significant

@manuel-uberti
Copy link
Contributor

@manuel-uberti manuel-uberti commented Sep 5, 2018

Ok, my bad then, it should not be needed for this PR.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Sep 6, 2018

Thanks. I renamed the face to ivy-modified-outside-buffer and adjusted the docstring and commit message. Please review.

@iquiw
Copy link
Contributor Author

@iquiw iquiw commented Sep 7, 2018

@abo-abo Thank you. The change is fine.

Sorry, but I just re-considered it is better that ivy-modified-outside-buffer takes precedence over ivy-modified-buffer. (Helm and smart-mode-line seem to do same)

If we change this, we might need to care the case when ivy-modified-buffer is configured but ivy-modified-outside-buffer not, since the latter is added newly.

Do you have any thought?

@iquiw iquiw deleted the outside-modified-face branch Sep 7, 2018
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Sep 7, 2018

Do you have any thought?

Yes, I think ivy-modified-outside-buffer should take priority. But we should not care if faces are customized or not: this should not affect the priority of their application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants