Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer ivy-modified-outside-buffer over ivy-modified-buffer #1745

Closed
wants to merge 2 commits into from

Conversation

@iquiw
Copy link
Contributor

commented Sep 8, 2018

As in #1742 (comment).

Also added the faces in the document.

iquiw added 2 commits Sep 8, 2018
ivy.el: Prefer ivy-modified-outside-buffer over ivy-modified-buffer
This behavior is same as some other packages like Helm, smart-mode-line.
@abo-abo

This comment has been minimized.

Copy link
Owner

commented Sep 9, 2018

Thanks, the PR looks good. But you'll need an Emacs CA in order for me to merge this. Are you willing to get it? Please see the README for more info.

@iquiw

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2018

@abo-abo Thanks for the review.

Yes, I wil try the CA procedure.

@iquiw

This comment has been minimized.

Copy link
Contributor Author

commented Nov 29, 2018

@abo-abo My assignment process was completed.

@abo-abo abo-abo closed this in 86635fb Nov 29, 2018

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Nov 29, 2018

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.