Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el: Simplify async xdg-open invocation #1760

Merged
merged 1 commit into from Sep 19, 2018

Conversation

@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Sep 19, 2018

(counsel-locate-action-extern): Avoid issues with start-process-shell-command returning too soon by passing 0 as the BUFFER argument to call-process-shell-command.

Re: #1537, #1759
Cc: @yiufung

(counsel-locate-action-extern): Avoid issues with
start-process-shell-command returning too soon by passing 0 as the
BUFFER argument to call-process-shell-command.

Re: #1537, #1759
@basil-conto basil-conto force-pushed the basil-conto:blc/xdg-open branch to 1621d35 Sep 19, 2018
@yiufung
Copy link

@yiufung yiufung commented Sep 19, 2018

It works on my end. Not sure if it works on other platforms though, if so it's a much cleaner solution.

@basil-conto
Copy link
Collaborator Author

@basil-conto basil-conto commented Sep 19, 2018

Not sure if it works on other platforms though

It should work on every platform that supports asynchronous subprocesses via make-process, start-process, etc. If it doesn't, that would be an Emacs bug which we'd have to work around.

(elisp) Synchronous Processes lists MS-DOS as an example of a platform lacking asynchronous subproceses, but Counsel never supported MS-DOS to begin with; that would be a separate bug.

@abo-abo abo-abo merged commit 1621d35 into abo-abo:master Sep 19, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Sep 19, 2018

Thanks.

@basil-conto basil-conto deleted the basil-conto:blc/xdg-open branch Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants