counsel.el: Simplify async xdg-open invocation #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(counsel-locate-action-extern): Avoid issues with start-process-shell-command returning too soon by passing 0 as the BUFFER argument to call-process-shell-command. Re: abo-abo#1537, abo-abo#1759
basil-conto
force-pushed
the
blc/xdg-open
branch
from
05d4b22
to
1621d35
Compare
|
It works on my end. Not sure if it works on other platforms though, if so it's a much cleaner solution. |
It should work on every platform that supports asynchronous subprocesses via
|
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(
counsel-locate-action-extern): Avoid issues withstart-process-shell-commandreturning too soon by passing0as theBUFFERargument tocall-process-shell-command.Re: #1537, #1759
Cc: @yiufung