Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.el: Don't restore buffer after action #1767

Merged
merged 1 commit into from Sep 26, 2018

Conversation

basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Sep 26, 2018

The call to with-current-buffer was made redundant by the preceding set-buffer added in #1607 (right @abo-abo?), and incorrectly restores ivy-state-buffer after calling action.

(ivy-call): Remove call to with-current-buffer.

Closes #1766
Cc: @mehw, @raxod502

The call to with-current-buffer was made redundant by the preceding
set-buffer added in abo-abo#1607, and incorrectly restores ivy-state-buffer
after calling action.

(ivy-call): Remove call to with-current-buffer.

Closes abo-abo#1766
@mehw
Copy link

@mehw mehw commented Sep 26, 2018

Remove call to with-current-buffer

@basil-conto it seems to work.

@ericdanan already spotted the problem in 717#issuecomment-321920963.

Could set-buffer suffice and with-current-buffer being definitely removed?

@abo-abo abo-abo merged commit 02d9528 into abo-abo:master Sep 26, 2018
1 check passed
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Sep 26, 2018

Thanks.

@basil-conto
Copy link
Collaborator Author

@basil-conto basil-conto commented Sep 27, 2018

@ericdanan already spotted the problem in #717 (comment).

Indeed, I would have attributed @ericdanan in the commit had I known; I'm sorry about that.

@basil-conto basil-conto deleted the blc/switch-buffer branch Sep 27, 2018
@ericdanan
Copy link
Contributor

@ericdanan ericdanan commented Sep 27, 2018

Indeed, I would have attributed @ericdanan in the commit had I known; I'm sorry about that.

It doesn't matter at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants