Skip to content

/swiper

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.el: Don't restore buffer after action #1767

Merged
merged 1 commit into from Sep 26, 2018

Conversation

@basil-conto
Copy link
Collaborator

commented Sep 26, 2018 •
edited

The call to with-current-buffer was made redundant by the preceding set-buffer added in #1607 (right @abo-abo?), and incorrectly restores ivy-state-buffer after calling action.

(ivy-call): Remove call to with-current-buffer.

Closes #1766
Cc: @mehw, @raxod502
@basil-conto
ivy.el: Don't restore buffer after action 
The call to with-current-buffer was made redundant by the preceding
set-buffer added in #1607, and incorrectly restores ivy-state-buffer
after calling action.

(ivy-call): Remove call to with-current-buffer.

Closes #1766
Verified
This commit was signed with a verified signature.
basil-conto Basil L. Contovounesios
GPG key ID: 205AB54A5D5D8CFF Learn about signing commits
Loading status checks…
02d9528
@basil-conto basil-conto referenced this pull request Sep 26, 2018
Closed
@mehw

This comment has been minimized.

Sign in to view
Copy link

commented Sep 26, 2018

Remove call to with-current-buffer

@basil-conto it seems to work.

@ericdanan already spotted the problem in 717#issuecomment-321920963.

Could set-buffer suffice and with-current-buffer being definitely removed?

@abo-abo abo-abo merged commit 02d9528 into abo-abo:master Sep 26, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo

This comment has been minimized.

Sign in to view
Copy link
Owner

commented Sep 26, 2018

Thanks.
@basil-conto

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Sep 27, 2018

@ericdanan already spotted the problem in #717 (comment).

Indeed, I would have attributed @ericdanan in the commit had I known; I'm sorry about that.

@basil-conto basil-conto deleted the basil-conto:blc/switch-buffer branch Sep 27, 2018

@ericdanan

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Sep 27, 2018

Indeed, I would have attributed @ericdanan in the commit had I known; I'm sorry about that.

It doesn't matter at all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@basil-conto @mehw @abo-abo @ericdanan
You can’t perform that action at this time.