ivy.el: Don't restore buffer after action #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to with-current-buffer was made redundant by the preceding set-buffer added in abo-abo#1607, and incorrectly restores ivy-state-buffer after calling action. (ivy-call): Remove call to with-current-buffer. Closes abo-abo#1766
@basil-conto it seems to work. @ericdanan already spotted the problem in 717#issuecomment-321920963. Could |
|
Thanks. |
Indeed, I would have attributed @ericdanan in the commit had I known; I'm sorry about that. |
It doesn't matter at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The call to
with-current-bufferwas made redundant by the precedingset-bufferadded in #1607 (right @abo-abo?), and incorrectly restoresivy-state-bufferafter callingaction.(
ivy-call): Remove call towith-current-buffer.Closes #1766
Cc: @mehw, @raxod502