Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el: Respect split string setting when doing grep-like occur. #1778

Closed
wants to merge 1 commit into from

Conversation

whatacold
Copy link
Contributor

@whatacold whatacold commented Oct 9, 2018

(counsel-grep-like-occur, counsel-git-grep-occur): Respect user
setting of counsel-async-split-string-re' when doing grep-like occur, so as to better support wgrep'.

Fixes #1384

Hi,

As mentioned in #1384, after setting (setq counsel-async-split-string-re "\r?\n") it does work for counsel-ag itself,
but there are still ^M when doing occur. So this PR tries to fix it.

Don't know if it's appropriate to use counsel-async-split-string-re for counsel-git-grep-occur,
as git grep isn't an async command IIUC.

(counsel-grep-like-occur, counsel-git-grep-occur): Respect user
setting of `counsel-async-split-string-re' when doing grep-like occur,
so as to better support `wgrep'.

Fixes abo-abo#1384
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 9, 2018

Thanks.

Don't know if it's appropriate to use counsel-async-split-string-re for counsel-git-grep-occur,
as git grep isn't an async command IIUC.

This is fine, I think.

@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Oct 9, 2018

Don't know if it's appropriate to use counsel-async-split-string-re for counsel-git-grep-occur, as git grep isn't an async command IIUC.

This is fine, I think.

Agreed, but perhaps the user option should be renamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants