Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el : Add counsel-separator face #1815

Closed
wants to merge 2 commits into from

Conversation

tttuuu888
Copy link
Contributor

@tttuuu888 tttuuu888 commented Nov 22, 2018

First of all, thanks for this great package.
I added counsel-separator face to make it easy to distinguish texts on counsel-yank-pop list.
when I eval (setq counsel-yank-pop-separator "\n----------\n"), separators on counsel-yank-pop list will be looked as below.

s1

s2

Thanks.

counsel.el Outdated
@@ -730,6 +730,12 @@ a symbol and how to search for them."
"Face used by `counsel-M-x' for key bindings."
:group 'ivy-faces)

;;** `counsel-yank-pop'
Copy link
Collaborator

@basil-conto basil-conto Nov 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This heading already exists later on in the file, no need to have it twice.

counsel.el Outdated
@@ -730,6 +730,12 @@ a symbol and how to search for them."
"Face used by `counsel-M-x' for key bindings."
:group 'ivy-faces)

;;** `counsel-yank-pop'
(defface counsel-separator
Copy link
Collaborator

@basil-conto basil-conto Nov 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring sounds pretty generic, perhaps this face should be added straight to ivy.el?

@tttuuu888
Copy link
Contributor Author

@tttuuu888 tttuuu888 commented Nov 22, 2018

@basil-conto Thanks for your review. I just added a commit to rename 'counsel-separator' to 'ivy-separator'.

@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Nov 22, 2018

Thanks @tttuuu888, LGTM.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Nov 24, 2018

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants