Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el : Add counsel-separator face #1815

Closed
wants to merge 2 commits into from

Conversation

@tttuuu888
Copy link
Contributor

commented Nov 22, 2018

First of all, thanks for this great package.
I added counsel-separator face to make it easy to distinguish texts on counsel-yank-pop list.
when I eval (setq counsel-yank-pop-separator "\n----------\n"), separators on counsel-yank-pop list will be looked as below.

s1

s2

Thanks.

counsel.el Outdated
@@ -730,6 +730,12 @@ a symbol and how to search for them."
"Face used by `counsel-M-x' for key bindings."
:group 'ivy-faces)

;;** `counsel-yank-pop'

This comment has been minimized.

Copy link
@basil-conto

basil-conto Nov 22, 2018

Collaborator

This heading already exists later on in the file, no need to have it twice.

counsel.el Outdated
@@ -730,6 +730,12 @@ a symbol and how to search for them."
"Face used by `counsel-M-x' for key bindings."
:group 'ivy-faces)

;;** `counsel-yank-pop'
(defface counsel-separator

This comment has been minimized.

Copy link
@basil-conto

basil-conto Nov 22, 2018

Collaborator

The docstring sounds pretty generic, perhaps this face should be added straight to ivy.el?

@tttuuu888 tttuuu888 force-pushed the tttuuu888:work-separator branch from d4ff728 to 7af3c5e Nov 22, 2018

@tttuuu888

This comment has been minimized.

Copy link
Contributor Author

commented Nov 22, 2018

@basil-conto Thanks for your review. I just added a commit to rename 'counsel-separator' to 'ivy-separator'.

@basil-conto

This comment has been minimized.

Copy link
Collaborator

commented Nov 22, 2018

Thanks @tttuuu888, LGTM.

@abo-abo abo-abo closed this in 9f52838 Nov 24, 2018

abo-abo added a commit that referenced this pull request Nov 24, 2018
@abo-abo

This comment has been minimized.

Copy link
Owner

commented Nov 24, 2018

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.