Various prompt fixes #1816
Merged
Various prompt fixes #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc/ivy.org: Update ivy-read prompt description after recent change[1] re: abo-abo#1350. doc/ivy.texi: Regenerate. [1]: ivy.el (ivy-read): prompt argument is no longer a format string 2018-11-22 09:39:35 +0100 6fe1a93
Don't ivy--quote-format-string prompt now that it is no longer interpreted as a format string[1]. [1]: ivy.el (ivy-read): prompt argument is no longer a format string 2018-11-22 09:39:35 +0100 6fe1a93 Re: abo-abo#1350
It duplicates the standard convention of ending user input prompts with a colon and space, and requires that its caller not add them, which is inconsistent with standard ivy-read usage. (counsel-prompt-function-default): Simplify and mark as obsolete. (counsel-prompt-function-dir): Handle the standard scenario where ivy-state-prompt already ends in a colon and space. (counsel-git, counsel-git-grep, counsel-ag): Replace counsel-prompt-function-default with explicit colon and space.
Narrow error condition to wrong-number-of-arguments. Specify 'ivy instead of default 'emacs custom group in warning message and mention caller associated with offending prompt function.
(ivy-set-prompt-text-properties-function): Extend docstring. (ivy-set-prompt-text-properties-default): Ditto and simplify. (ivy--set-match-props): Remove unneeded function.
(ivy-read, ivy-completion-in-region, ivy-cleanup-string): Use it.
(ivy-completion-in-region-prompt): New function. (ivy-completion-in-region): Use it as prompt function instead of overriding user-configurable ivy--prompts-list. Do not override user option ivy-count-format.
(counsel-expression-history, counsel-shell-command-history): Use declare form instead of make-obsolete.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Please review each commit in turn.
Re: #1350