Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy-overlay.el: Simplify overlay face overriding #1825

Merged
merged 2 commits into from Nov 27, 2018

Conversation

basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Nov 27, 2018

This is a refactor of commit 7434a79.

(ivy--overlay-font-lock-hack): Remove.
(ivy-overlay-show-after): Specify default face of ivy-overlay-at to avoid clashing with other overlays.

Re: #1016, #1488, #1520, #1547, #1808

basil-conto added 2 commits Nov 27, 2018
This is a refactor of the following commit:

ivy-overlay.el (ivy-overlay-show-after): Don't inherit existing face
  2018-11-27 12:31:32 +0100 7434a79

(ivy--overlay-font-lock-hack): Remove.
(ivy-overlay-show-after): Specify default face of ivy-overlay-at to
avoid clashing with other overlays.

Re: abo-abo#1016, abo-abo#1488, abo-abo#1520, abo-abo#1547, abo-abo#1808
ivy-overlay.el (ivy-display-function-overlay): Use point-min instead
of hard-coded position.  Simplify string concatenation.
@basil-conto
Copy link
Collaborator Author

@basil-conto basil-conto commented Nov 27, 2018

Note that specifying default face attributes is not necessarily a hack/kludge; it is necessitated, to an extent, by the mechanism Emacs uses to calculate faces: see (elisp) Displaying Faces.

@abo-abo abo-abo merged commit 3d301d7 into abo-abo:master Nov 27, 2018
1 of 2 checks passed
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Nov 27, 2018

That's a nice simplification. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants