counsel.el: Call du process directly #1827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(counsel--git-grep-count-func-default): Call git and du directly to avoid shell incompatibilities in redirection. Re: abo-abo#1470, abo-abo#1558 Fixes abo-abo#1502
abo-abo
added a commit
that referenced
this pull request
Nov 28, 2018
|
Thanks. Please also have a look at the new wrapper. I used |
basil-conto
added a commit
to basil-conto/swiper
that referenced
this pull request
Nov 28, 2018
Use process-file instead of call-process. Add docstring. Avoid
multi-line error message by returning only the first line of stderr.
Deconstruct error information as file-error data for easier access.
Guard stderr file access with file-{exists,readable}-p just in case.
Re: abo-abo#1827
Thanks, I've submitted a few suggestions in #1828.
I think so too, given shell commands obey file handlers. |
basil-conto
added a commit
to basil-conto/swiper
that referenced
this pull request
Nov 28, 2018
Use process-file instead of call-process. Add docstring. Avoid
multi-line error message by returning only the first line of stderr.
Deconstruct error information as file-error data for easier access.
Guard stderr file access with file-{exists,readable}-p just in case.
Re: abo-abo#1827
basil-conto
added a commit
to basil-conto/swiper
that referenced
this pull request
Nov 28, 2018
Use process-file instead of call-process. Add docstring. Avoid
multi-line error message by returning only the first line of stderr.
Deconstruct error information as file-error data for easier access.
Guard stderr file access with file-{exists,readable}-p just in case.
Re: abo-abo#1827
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(
counsel--git-grep-count-func-default): Callgitanddudirectly to avoid shell incompatibilities in redirection.Cc: @articuluxe, @icarus-sparry, @mikecrowe, @shalin24
Re: #1470, #1558
Fixes #1502
P.S. Sorry for not commenting on this at the time, but why do
counsel--git-grep-count,counsel--git-grep-count-func, andcounsel--git-grep-count-func-defaulthave double hyphens in their names, if they're intended as a means for (advanced) user customisation?Re: #1470 (comment)
Wouldn't it be cleaner to allow values of
ivy-more-chars-alistto be functions, so thativy-more-charsis no longer guarded ad-hoc by(> counsel--git-grep-count counsel--git-grep-count-threshold)incounsel-git-grep-function?