ivy.el (ivy--magic-file-slash): Fix dir expansion #1831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand ivy-text against ivy--directory, not default-directory. Perhaps the commentary of [1] was correct in that default-directory should be bound to ivy--directory more generally here. [1]: ivy.el (ivy--magic-file-slash): Change priority in cond 2017-04-13 17:09:47 +0200 f94c15c Fixes abo-abo#1829
Quote function symbols as such. Assume default-directory is non-nil. Do not unnecessarily modify match data. An existent directory is also an existent file.
Remove duplicate ivy-magic-slash-non-match-create cond branch.
Tidy up ivy-magic-slash-non-match-cd-selected cond guard.
Lift common subexpressions, namely expanded ivy-text and boolean indicating whether ivy-text comprises more than just a single slash.
|
Thanks. Would be cool to eventually add some tests to this. |
|
Does "closed" mean this PR was accepted and merged, or rejected without merge? |
|
@dwang20151005 Means it's merged. You can check it if you look at the commit message. Github doesn't recognize it as merged because I had to rebase the PR on top of new changes. |
|
Got it, thanks. (Sorry, not familiar with git/github.) |
astoff
pushed a commit
to astoff/swiper
that referenced
this issue
Jan 1, 2021
Lift common subexpressions, namely expanded ivy-text and boolean indicating whether ivy-text comprises more than just a single slash. Fixes abo-abo#1831
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Please review each commit in turn. The first commit addresses #1829 and its commentary follows. The remaining commits are merely logic simplifications of the surrounding code.
Cc: @dwang20151005
Expand
ivy-textagainstivy--directory, notdefault-directory.Perhaps the commentary of [1] was correct in that
default-directoryshould be bound toivy--directorymore generally here.[1]:
ivy.el(ivy--magic-file-slash): Change priority incond2017-04-13 17:09:47 +0200 f94c15c