Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upivy.el (ivy--magic-file-slash): Fix dir expansion #1831
Conversation
abo-abo
closed this
in
4fdc8f8
Dec 13, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks. Would be cool to eventually add some tests to this. |
This comment has been minimized.
This comment has been minimized.
dwang20151005
commented
Dec 13, 2018
|
Does "closed" mean this PR was accepted and merged, or rejected without merge? |
This comment has been minimized.
This comment has been minimized.
|
@dwang20151005 Means it's merged. You can check it if you look at the commit message. Github doesn't recognize it as merged because I had to rebase the PR on top of new changes. |
This comment has been minimized.
This comment has been minimized.
dwang20151005
commented
Dec 13, 2018
|
Got it, thanks. (Sorry, not familiar with git/github.) |
basil-conto
deleted the
basil-conto:blc/magic
branch
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
basil-conto commentedNov 30, 2018
•
edited
Please review each commit in turn. The first commit addresses #1829 and its commentary follows. The remaining commits are merely logic simplifications of the surrounding code.
Cc: @dwang20151005
Expand
ivy-textagainstivy--directory, notdefault-directory.Perhaps the commentary of [1] was correct in that
default-directoryshould be bound toivy--directorymore generally here.[1]:
ivy.el(ivy--magic-file-slash): Change priority incond2017-04-13 17:09:47 +0200 f94c15c