Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid to wipe a user buffer when writing candidates. #1837

Closed
wants to merge 1 commit into from

Conversation

mookid
Copy link
Contributor

@mookid mookid commented Dec 2, 2018

Fix #1772.

I was able to reproduce the issue with counsel-ag, and I suspect that the bug impacts any usage of counsel--async-command as well.

My guess is that counsel--async-filter is a caller of ivy--insert-minibuffer, which must only be called when the current buffer is the minibuffer (ie, ivy--insert-minibuffer is not wrapped in a with-current-buffer block).

When called with a process that exists immediately, it is very unlikely that the process filter will be called at all, and even less before the user had time to change buffer himself.

@jojojames can you confirm that this version fixes the issue?

counsel.el Outdated Show resolved Hide resolved
@jojojames
Copy link
Contributor

@jojojames jojojames commented Dec 2, 2018

@mookid Thanks for the fix!

I'll be a little busy for the next few weeks to a month but I'll see if I can squeeze in some time to test this.

Thanks.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Dec 12, 2018

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants