Robustify counsel occur #1845
Closed
Robustify counsel occur #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit be98b75.
basil-conto
reviewed
Dec 8, 2018
counsel.el
Outdated
| @@ -1491,6 +1491,9 @@ If NO-ASYNC is non-nil, do it synchronously instead." | |||
| nil " *counsel-gg-count*") | |||
| nil)))) | |||
|
|
|||
| (defun counsel--normalize-grep-match (str) | |||
| (if (string-prefix-p "\\.[/\\]" str) str (concat "./" str))) | |||
There was a problem hiding this comment.
Should this be string-match-p?
There was a problem hiding this comment.
hum I don't want to match a path such as "foo./bar"
There was a problem hiding this comment.
oh got it. string-prefix-p does not handle regexps
counsel--normalize-grep-match: new function. counsel-git-grep-occur: use the new function. counsel--grep-mode-occur: use the new function. counsel-grep-like-occur: force normalization of completion candidates.
|
Thanks. |
|
Either Re: #1846 |
abo-abo
added a commit
that referenced
this issue
Dec 17, 2018
|
@basil-conto Thanks. |
astoff
pushed a commit
to astoff/swiper
that referenced
this issue
Jan 1, 2021
astoff
pushed a commit
to astoff/swiper
that referenced
this issue
Jan 1, 2021
astoff
pushed a commit
to astoff/swiper
that referenced
this issue
Jan 1, 2021
(ivy--dirname-p, ivy--magic-file-slash): Simplify now that Ivy requires Emacs 24.5 or later by using string-suffix-p instead of slower regexp matching. (ivy--occur-insert-lines): Escape leading dot in regexp by using existing helper ivy--starts-with-dotslash. Re: abo-abo#1817, abo-abo#1845, abo-abo#1846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
see be98b75
the implemented strategy: always prefix matches with ./ or ., regardless of whether the tool (ie, ag or rg or git-grep or pt or......) adds it.
As mentioned, this fixes the broken navigation from the results of ag-based ivy-occur buffers.