ivy.el (ivy--occur-insert-lines): fix incorrect regexp.

[mookid]

Currently the . seems too permissive and should be escaped.

the correct one was given by @basil-conto in #1817 (comment) of course (:

[basil-conto]

delete can be delq here.

[basil-conto]

Nitpick: Strings and symbols are self-quoting, and we're not modifying the alist, so a literal '(("..." . ok) ...) would suffice here.

Having said that, I think this test can be written in a more straight-forward way:

(mapc (lambda (p)
        (should (eq (and (ivy--starts-with-dotslash (car p)) t)
                    (cdr p))))
      '(("./test1" . t)
        (".\\test2" . t)
        ("test3")
        ("t/est4")
        ("t\\est5")
        ("tes./t6")))

or similar. Having said that, it is more idiomatic to keep logic to a minimum in ERT tests:

(should (ivy--starts-with-dotslash "./test1"))
(should (ivy--starts-with-dotslash ".\\test2"))
(should (not (ivy--starts-with-dotslash "test3")))
(should (not (ivy--starts-with-dotslash "t/est4")))
(should (not (ivy--starts-with-dotslash "t\\est5")))
(should (not (ivy--starts-with-dotslash "tes./t6")))

Although I'm not usually a fan of repeating myself, tests are an exception where the latter style is instantly more obvious and possibly produces cleaner backtraces (though I'm not sure about this last point).

[mookid]

I did not really pay much attention to the way these were written to be honest.
I like the last option more.

[abo-abo]

Thanks.