Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more hardcoded faces #1847

Closed
wants to merge 6 commits into from

Conversation

@mookid
Copy link
Contributor

commented Dec 8, 2018

#1839

and also, add 'ivy-faces group when applicable.

ivy.el Outdated Show resolved Hide resolved
counsel.el Outdated Show resolved Hide resolved
ivy.el Outdated Show resolved Hide resolved
ivy.el Outdated Show resolved Hide resolved

@mookid mookid force-pushed the mookid:remove_hardcoded_faces branch from 2e6cbce to d75b468 Dec 8, 2018

@mookid

This comment has been minimized.

Copy link
Contributor Author

commented Dec 8, 2018

thanks for the review!

@basil-conto

This comment has been minimized.

Copy link
Collaborator

commented Dec 8, 2018

Thanks for working on this!

@mookid mookid force-pushed the mookid:remove_hardcoded_faces branch from e32e578 to 82f0f15 Dec 9, 2018

counsel.el Outdated Show resolved Hide resolved
doc/Changelog.org Outdated Show resolved Hide resolved
counsel.el Outdated Show resolved Hide resolved
counsel.el Outdated Show resolved Hide resolved
counsel.el Outdated Show resolved Hide resolved
counsel.el Outdated Show resolved Hide resolved
ivy.el Outdated Show resolved Hide resolved
mookid added 5 commits Dec 8, 2018
Remove hardcoded font-lock-comment-face.
counsel.el: (counsel-variable-documentation): new face.
(counsel-set-variable): use counsel-variable-documentation.
Remove hardcoded font-lock-builtin-face 1/2.
counsel.el: (counsel-application-name): new face.
(counsel-linux-app-format-function-default): use counsel-application-name.
(counsel-linux-app-format-function-name-first): use counsel-application-name.
Remove hardcoded font-lock-builtin-face 2/2.
counsel.el (counsel--descbinds-cands): use counsel-key-binding.
Remove hardcoded completions-annotations face.
ivy.el (ivy-completions-annotations): new face.
(ivy--format-minibuffer-line): use ivy-completions-annotations.
Remove hardcoded org-level-{1-8} faces.
counsel.el: (counsel-outline-{1,8}): new faces.
(counsel-outline--add-face): use counsel-outline-{1,8} faces.

@mookid mookid force-pushed the mookid:remove_hardcoded_faces branch from 82f0f15 to ce178a4 Dec 10, 2018

@mookid

This comment has been minimized.

Copy link
Contributor Author

commented Dec 10, 2018

thanks again @basil-conto

Remove hardcoded minibuffer-prompt face.
counsel.el: (counsel-outline-default): new face.
(counsel-outline--add-face): use counsel-outline-default.

@mookid mookid force-pushed the mookid:remove_hardcoded_faces branch from ce178a4 to 5091bdb Dec 10, 2018

@abo-abo abo-abo closed this in f751471 Dec 12, 2018

abo-abo added a commit that referenced this pull request Dec 12, 2018
@abo-abo

This comment has been minimized.

Copy link
Owner

commented Dec 12, 2018

Thanks.

@mookid mookid deleted the mookid:remove_hardcoded_faces branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.