Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.el: highlight yanked word. #1850

Closed
wants to merge 1 commit into from

Conversation

@mookid
Copy link
Contributor

commented Dec 8, 2018

A follow-up to #1581.

A very simple implementation with a global. Not a big deal as it is only displayed for a short time in any case.

cc @hotpxl

ivy.el Outdated Show resolved Hide resolved
ivy.el Outdated Show resolved Hide resolved
ivy.el Show resolved Hide resolved
ivy.el Outdated Show resolved Hide resolved
ivy.el Show resolved Hide resolved
ivy.el Outdated Show resolved Hide resolved

@mookid mookid force-pushed the mookid:pulse-yank branch 2 times, most recently from 1de4df6 to 2117e7f Dec 9, 2018

ivy.el: highlight yanked word.
(ivy-yanked-word): new face.
(ivy--pulse-overlay): new variable.
(ivy--pulse-timer): new variable.
(ivy--pulse-region): new function.

@mookid mookid force-pushed the mookid:pulse-yank branch from 2117e7f to 3b5c8ba Dec 9, 2018

@abo-abo abo-abo closed this in 71fe93c Dec 12, 2018

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Dec 12, 2018

Thanks.

@mookid mookid deleted the mookid:pulse-yank branch Dec 12, 2018

basil-conto added a commit to basil-conto/swiper that referenced this pull request Dec 13, 2018
ivy.el: Touch up yank pulsing
(ivy-pulse-delay): New variable.
(ivy--pulse-timer): Add markup to docstring.
(ivy--pulse-region): If ivy--pulse-overlay still exists from the
previous invocation, expand its region, rather than moving it.
Remove redundant call to move-overlay.  Use ivy-pulse-delay.
(ivy--pulse-cleanup): New function for ensuring ivy--pulse-timer and
ivy--pulse-overlay are disposed of.

Re: abo-abo#1581, abo-abo#1850
abo-abo added a commit that referenced this pull request Dec 13, 2018
ivy.el: Touch up yank pulsing
(ivy-pulse-delay): New variable.
(ivy--pulse-timer): Add markup to docstring.
(ivy--pulse-region): If ivy--pulse-overlay still exists from the
previous invocation, expand its region, rather than moving it.
Remove redundant call to move-overlay.  Use ivy-pulse-delay.
(ivy--pulse-cleanup): New function for ensuring ivy--pulse-timer and
ivy--pulse-overlay are disposed of.

Re: #1581, #1850
Fixes #1856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.