Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAnother try to fix #1772: avoid to erase non-minibuffers content #1857
Conversation
mookid
changed the title
Another try to fix #1772: avoid the erase non-minibuffers content
Another try to fix #1772: avoid to erase non-minibuffers content
Dec 13, 2018
mookid
closed this
Dec 14, 2018
mookid
reopened this
Dec 14, 2018
basil-conto
reviewed
Dec 14, 2018
mookid
force-pushed the
mookid:fix-wipe-buffer-content
branch
from
99576c4
to
d3136f1
Dec 15, 2018
abo-abo
merged commit d3136f1
into
abo-abo:master
Dec 17, 2018
1 check passed
This comment has been minimized.
This comment has been minimized.
|
Thanks. |
mookid
deleted the
mookid:fix-wipe-buffer-content
branch
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mookid commentedDec 13, 2018
•
edited
see #1837 and #1772
I can still reproduce the original bug:
sometimes when starting for instance counsel-rg and maintaining M-j pressed, the buffer where counsel-rg has been called is erased.
Hence propagate the fix so that the body of ivy--insert-minibuffer is protected against window changes.
Question @abo-abo should we keep functions such as ivy--cleanup that 1. assume that the current buffer is the minibuffer 2. are used only once?