Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another try to fix #1772: avoid to erase non-minibuffers content #1857

Merged
merged 2 commits into from Dec 17, 2018

Conversation

@mookid
Copy link
Contributor

commented Dec 13, 2018

see #1837 and #1772

I can still reproduce the original bug:

sometimes when starting for instance counsel-rg and maintaining M-j pressed, the buffer where counsel-rg has been called is erased.

Hence propagate the fix so that the body of ivy--insert-minibuffer is protected against window changes.

Question @abo-abo should we keep functions such as ivy--cleanup that 1. assume that the current buffer is the minibuffer 2. are used only once?

@mookid mookid changed the title Another try to fix #1772: avoid the erase non-minibuffers content Another try to fix #1772: avoid to erase non-minibuffers content Dec 13, 2018

@mookid mookid closed this Dec 14, 2018

@mookid mookid reopened this Dec 14, 2018

ivy.el Outdated Show resolved Hide resolved

@mookid mookid force-pushed the mookid:fix-wipe-buffer-content branch from 99576c4 to d3136f1 Dec 15, 2018

@abo-abo abo-abo merged commit d3136f1 into abo-abo:master Dec 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo

This comment has been minimized.

Copy link
Owner

commented Dec 17, 2018

Thanks.

@mookid mookid deleted the mookid:fix-wipe-buffer-content branch Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.