Another try to fix #1772: avoid to erase non-minibuffers content #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the minibuffer." This reverts commit 0355c55.
mookid
changed the title
basil-conto
reviewed
Dec 14, 2018
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
see #1837 and #1772
I can still reproduce the original bug:
sometimes when starting for instance counsel-rg and maintaining M-j pressed, the buffer where counsel-rg has been called is erased.
Hence propagate the fix so that the body of ivy--insert-minibuffer is protected against window changes.
Question @abo-abo should we keep functions such as ivy--cleanup that 1. assume that the current buffer is the minibuffer 2. are used only once?