Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.el: allow to make the initial-input dynamic. #1868

Closed
wants to merge 1 commit into from

Conversation

@mookid
Copy link
Contributor

commented Dec 20, 2018

This allows for instance to use customizations such as

(lambda ()
  (thing-at-point 'symbol))

in ivy-initial-inputs-alist.

related to #1867

@mookid mookid force-pushed the mookid:dyn-input branch 2 times, most recently from 976c182 to 2a314b8 Dec 20, 2018

ivy.el Outdated Show resolved Hide resolved
ivy.el Outdated Show resolved Hide resolved
ivy.el Outdated Show resolved Hide resolved
ivy.el Outdated Show resolved Hide resolved
@basil-conto

This comment has been minimized.

Copy link
Collaborator

commented Dec 23, 2018

fix #1867

#1867 is about :def, not :initial-input, so this PR does not fix that issue. #1867 only tangentially mentions ivy-initial-inputs-alist.

ivy.el Outdated Show resolved Hide resolved
ivy.el: allow to make the initial-input dynamic.
This allows for instance to use customizations such as
(lambda ()
  (thing-at-point 'symbol))

(ivy-initial-inputs-alist): cdrs of the alist can now be functions.
(ivy--reset-state): adapt.

@mookid mookid force-pushed the mookid:dyn-input branch from 2a314b8 to 2734758 Dec 23, 2018

@mookid

This comment has been minimized.

Copy link
Contributor Author

commented Dec 23, 2018

Thanks for the review.

@basil-conto

This comment has been minimized.

Copy link
Collaborator

commented Dec 23, 2018

Thanks for working on this!

@abo-abo abo-abo closed this in 201c5d7 Dec 23, 2018

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Dec 23, 2018

Thanks.

@mookid mookid deleted the mookid:dyn-input branch Dec 23, 2018

@mookid mookid referenced this pull request Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.