Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.el: allow to make the initial-input dynamic. #1868

Closed
wants to merge 1 commit into from

Conversation

mookid
Copy link
Contributor

@mookid mookid commented Dec 20, 2018

This allows for instance to use customizations such as

(lambda ()
  (thing-at-point 'symbol))

in ivy-initial-inputs-alist.

related to #1867

@mookid mookid force-pushed the dyn-input branch 2 times, most recently from 976c182 to 2a314b8 Compare Dec 21, 2018
ivy.el Outdated Show resolved Hide resolved
ivy.el Outdated Show resolved Hide resolved
ivy.el Outdated Show resolved Hide resolved
ivy.el Outdated Show resolved Hide resolved
@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Dec 23, 2018

fix #1867

#1867 is about :def, not :initial-input, so this PR does not fix that issue. #1867 only tangentially mentions ivy-initial-inputs-alist.

ivy.el Outdated Show resolved Hide resolved
This allows for instance to use customizations such as
(lambda ()
  (thing-at-point 'symbol))

(ivy-initial-inputs-alist): cdrs of the alist can now be functions.
(ivy--reset-state): adapt.
@mookid
Copy link
Contributor Author

@mookid mookid commented Dec 23, 2018

Thanks for the review.

@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Dec 23, 2018

Thanks for working on this!

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Dec 23, 2018

Thanks.

@mookid mookid deleted the dyn-input branch Dec 23, 2018
@mookid mookid mentioned this pull request Dec 24, 2018
astoff pushed a commit to astoff/swiper that referenced this issue Jan 1, 2021
This allows for instance to use customizations such as
(lambda ()
  (thing-at-point 'symbol))

(ivy-initial-inputs-alist): cdrs of the alist can now be functions.
(ivy--reset-state): adapt.

Fixes abo-abo#1868
Re abo-abo#1867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants