New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ivy-count-format to be set as nil #188

Merged
merged 1 commit into from Aug 1, 2015

Conversation

Projects
None yet
2 participants
@xuchunyang
Contributor

xuchunyang commented Aug 1, 2015

According to the documentation of ivy-count-format, user should be able to set it to nil for disabling the count feature, but now it won't work since ivy-count-format has to be a string, otherwise if its value is nil, a "wrong-type-argument" error will raise.

@abo-abo abo-abo merged commit b8b951b into abo-abo:master Aug 1, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Aug 1, 2015

Owner

Thanks!

Owner

abo-abo commented Aug 1, 2015

Thanks!

@xuchunyang xuchunyang deleted the xuchunyang:allow-count-format-to-be-nil branch Aug 1, 2015

abo-abo added a commit that referenced this pull request Oct 10, 2015

ivy-count-format must be an empty string instead of nil
Using an empty string is easier. No longer needed to check for nil when
using `string-match', `concat' etc.

* doc/Changelog.org: Update.

* ivy.el (ivy-count-format): Update doc and customize type.
(ivy--reset-state): Error if `ivy-count-format' nil is encountered.

Fixes #257
Re  #188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment