Skip to content

Allow ivy-count-format to be set as nil #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2015
Merged

Allow ivy-count-format to be set as nil #188

merged 1 commit into from
Aug 1, 2015

Conversation

@xuchunyang
Copy link
Contributor

@xuchunyang xuchunyang commented Aug 1, 2015

According to the documentation of ivy-count-format, user should be able to set it to nil for disabling the count feature, but now it won't work since ivy-count-format has to be a string, otherwise if its value is nil, a "wrong-type-argument" error will raise.

@abo-abo abo-abo merged commit b8b951b into abo-abo:master Aug 1, 2015
@abo-abo
Copy link
Owner

abo-abo commented Aug 1, 2015

Thanks!

@xuchunyang xuchunyang deleted the allow-count-format-to-be-nil branch August 1, 2015 07:36
abo-abo added a commit that referenced this pull request Oct 10, 2015
@abo-abo
ivy-count-format must be an empty string instead of nil
340318d 
Using an empty string is easier. No longer needed to check for nil when
using `string-match', `concat' etc.

* doc/Changelog.org: Update.

* ivy.el (ivy-count-format): Update doc and customize type.
(ivy--reset-state): Error if `ivy-count-format' nil is encountered.

Fixes #257
Re  #188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xuchunyang @abo-abo