Allow ivy-count-format to be set as nil #188

Merged
merged 1 commit into from Aug 1, 2015

Projects

None yet

2 participants

@xuchunyang
Contributor

According to the documentation of ivy-count-format, user should be able to set it to nil for disabling the count feature, but now it won't work since ivy-count-format has to be a string, otherwise if its value is nil, a "wrong-type-argument" error will raise.

@xuchunyang xuchunyang Allow ivy-count-format to be set as nil
b8b951b
@abo-abo abo-abo merged commit b8b951b into abo-abo:master Aug 1, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo
Owner
abo-abo commented Aug 1, 2015

Thanks!

@xuchunyang xuchunyang deleted the xuchunyang:allow-count-format-to-be-nil branch Aug 1, 2015
@abo-abo abo-abo added a commit that referenced this pull request Oct 10, 2015
@abo-abo ivy-count-format must be an empty string instead of nil
Using an empty string is easier. No longer needed to check for nil when
using `string-match', `concat' etc.

* doc/Changelog.org: Update.

* ivy.el (ivy-count-format): Update doc and customize type.
(ivy--reset-state): Error if `ivy-count-format' nil is encountered.

Fixes #257
Re  #188
340318d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment