Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiper.el (swiper-font-lock-exclude): Add matrix-client-mode #1886

Closed
wants to merge 1 commit into from

Conversation

@DamienCassou
Copy link
Contributor

@DamienCassou DamienCassou commented Jan 10, 2019

Thanks to @alphapapa for finding the cause of the problem.

@DamienCassou
Copy link
Contributor Author

@DamienCassou DamienCassou commented Jan 10, 2019

On https://matrix.to/#/#matrix-client.el:matrix.org, @alphapapa suggested that swiper could use a whitelist instead of a blacklist to know if font-lock-ensure can be called. The whitelist could use derived-mode-p on prog-mode to already cover many of the cases.

@DamienCassou DamienCassou force-pushed the DamienCassou:fix-matrix-client branch 2 times, most recently from f4f7159 to 6fa470e Jan 10, 2019
Thanks to @alphapapa for finding the cause of the problem.
@DamienCassou DamienCassou force-pushed the DamienCassou:fix-matrix-client branch from 6fa470e to 111975b Jan 22, 2019
@DamienCassou
Copy link
Contributor Author

@DamienCassou DamienCassou commented Jan 22, 2019

ping

@abo-abo abo-abo closed this in a0a671f Jan 22, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jan 22, 2019

Thanks.

The whitelist could use derived-mode-p on prog-mode to already cover many of the cases.

Nice idea. But this approach could also have some corner cases. The corner cases of the blacklist approach have been more or less figured out, I rarely see issues like this one.

@DamienCassou DamienCassou deleted the DamienCassou:fix-matrix-client branch Jan 22, 2019
astoff added a commit to astoff/swiper that referenced this pull request Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants