Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add find args customization for counsel-{file,dired}-jump #1889

Closed
wants to merge 1 commit into from

Conversation

@errge
Copy link
Contributor

commented Jan 16, 2019

This is useful, because I use counsel in a big symlink farm, so the
default behaviour of "-type f" has to be repaced for me with "-type
f,l". Other customization is e.g. inclusion of hidden files, as the
default is using * glob, that doesn't match hidden directories.

@mookid

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2019

See #1872 as well.

@errge

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2019

@mookid, I know about that, and I think it is very nice, that you are making progress there and working on it.

In the meantime, my change is a lot simpler, as it is just a customization, so I was hoping it's less controversial and quicker to review. After that, when your stuff is ready, feel free to remove/adjust my customization as necessary!

Thanks for all your work!

counsel.el Outdated Show resolved Hide resolved
counsel.el Outdated Show resolved Hide resolved
counsel.el Outdated Show resolved Hide resolved
counsel.el Outdated Show resolved Hide resolved

@errge errge force-pushed the nilcons-contrib:master branch from 5cc8ac4 to 2cb4fbd Jan 16, 2019

counsel.el Outdated Show resolved Hide resolved
Add find args customization for counsel-{file,dired}-jump
This is useful, because I use counsel in a big symlink farm, so the
default behaviour of "-type f" has to be repaced for me with "-type
f,l".  Other customization is e.g. inclusion of hidden files, as the
default is using * glob, that doesn't match hidden directories.

@errge errge force-pushed the nilcons-contrib:master branch from 2cb4fbd to 727dd75 Jan 18, 2019

@errge

This comment has been minimized.

Copy link
Contributor Author

commented Jan 18, 2019

@Alexander-Shukaev Thanks for looking out, I somehow missed that. Now it should be fixed. Cheers!

@Alexander-Shukaev

This comment has been minimized.

Copy link

commented Jan 18, 2019

👍

@abo-abo abo-abo closed this in b31449a Jan 21, 2019

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Jan 21, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.