Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not let ivy virtual buffer faces creep into the recentf file #1898

Merged
merged 1 commit into from Jan 21, 2019

Conversation

errge
Copy link
Contributor

@errge errge commented Jan 20, 2019

We have to use copy-sequence before setting faces, otherwise the
user's ~/.emacs.d/recentf file will contain the reference to faces.
Since strings with or without text-properties are semantically
equivalent in elisp, this doesn't cause any issues, but is certainly
ugly and confusing to users who are not familiar with elisp/ivy
internals.

We have to use `copy-sequence` before setting faces, otherwise the
user's ~/.emacs.d/recentf file will contain the reference to faces.
Since strings with or without text-properties are semantically
equivalent in elisp, this doesn't cause any issues, but is certainly
ugly and confusing to users who are not familiar with elisp/ivy
internals.
@abo-abo abo-abo merged commit d7ba75b into abo-abo:master Jan 21, 2019
1 of 2 checks passed
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jan 21, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants