Do not let ivy virtual buffer faces creep into the recentf file #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to use `copy-sequence` before setting faces, otherwise the user's ~/.emacs.d/recentf file will contain the reference to faces. Since strings with or without text-properties are semantically equivalent in elisp, this doesn't cause any issues, but is certainly ugly and confusing to users who are not familiar with elisp/ivy internals.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We have to use
copy-sequencebefore setting faces, otherwise theuser's ~/.emacs.d/recentf file will contain the reference to faces.
Since strings with or without text-properties are semantically
equivalent in elisp, this doesn't cause any issues, but is certainly
ugly and confusing to users who are not familiar with elisp/ivy
internals.