Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el (counsel-M-x): Optionally expand aliases #1904

Merged
merged 1 commit into from Jan 27, 2019

Conversation

andschwa
Copy link
Contributor

@andschwa andschwa commented Jan 27, 2019

Added support via counsel-M-x-transformer to show the expansion of an
alias in a manner similar to how keybindings are shown. For example, if
rb is aliased to revert-buffer, and bound to C-c r, M-x rb will
show rb (revert-buffer) (C-c r).

Currently the expansion is in the same font as the command, which looks
nice, but it would be easy to add support for a custom face.

The boolean counsel-alias-expand was introduced to enable or disable
this functionality, with it defaulting to non-nil.

Added support via `counsel-M-x-transformer` to show the expansion of an
alias in a manner similar to how keybindings are shown. For example, if
`rb` is aliased to `revert-buffer`, and bound to `C-c r`, `M-x rb` will
show `rb (revert-buffer) (C-c r)`.

Currently the expansion is in the same font as the command, which looks
nice, but it would be easy to add support for a custom face.

The boolean `counsel-alias-expand` was introduced to enable or disable
this functionality, with it defaulting to non-nil.
@andschwa
Copy link
Contributor Author

@andschwa andschwa commented Jan 27, 2019

I have a copyright assignment in progress with the FSF, this reminded me I need to get something signed by my employer.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jan 27, 2019

Thanks, looks good to me. I think I can merge this without an assignment, this is below the 15 lines limit. But it's good that you have applied for one.

@abo-abo abo-abo merged commit 100bd21 into abo-abo:master Jan 27, 2019
1 of 2 checks passed
@andschwa andschwa deleted the alias-expand branch Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants