Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.el (ivy--kill-buffer-action): Integrate with ivy-switch-buffer-kill #1910

Closed
wants to merge 1 commit into from

Conversation

@iquiw
Copy link
Contributor

@iquiw iquiw commented Jan 30, 2019

This moves logic in ivy-switch-buffer-kill into ivy--kill-buffer-action
and calls the latter from the former, so that ivy--kill-buffer-action
acts as same as ivy-switch-buffer-kill.

Previously, `ivy--kill-buffer-action' does not preserve the index after kill.

Fixes #1787

This moves logic in `ivy-switch-buffer-kill' into `ivy--kill-buffer-action'
and calls the latter from the former, so that `ivy--kill-buffer-action'
acts as same as `ivy-switch-buffer-kill'.

Previously, `ivy--kill-buffer-action' does not preserve the index
after kill.
@abo-abo abo-abo closed this in c2eb4b5 Jan 30, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jan 30, 2019

Thanks.

@iquiw iquiw deleted the kill-buffer-unification branch Jan 30, 2019
astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
This moves logic in `ivy-switch-buffer-kill' into `ivy--kill-buffer-action'
and calls the latter from the former, so that `ivy--kill-buffer-action'
acts as same as `ivy-switch-buffer-kill'.

Previously, `ivy--kill-buffer-action' does not preserve the index
after kill.

Fixes abo-abo#1910
Fixes abo-abo#1787
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants