-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment variable completion to counsel-find-file #1932
Conversation
c931c6f
to
59d964e
Compare
I moved back to the original implementation after applying feedback. If @abo-abo or someone knows how to make the quitting recursive minibuffers work in the |
59d964e
to
ef78fb6
Compare
I realized that this implementation does not work with |
Suppose an (ivy-read "test: " '("1" "2" "3")) is done when another `ivy-read' is in progress. In that case, after the first `ivy-read' returns a string, we should restore the state of the first `ivy-read'. Re #1932
@CeleritasCelery Thanks, please test. I've re-written a portion of your code to simplify it. I think it now falls into the 15 lines limit that's exempt from an Emacs CA. But you'll need a CA for future (hopefully) contributions. |
Thanks @abo-abo. I have already applied for a CA. Hear it takes about a month. I am impressed how much you were able to simplify what I had added. I only see two issues:
(when (file-accessible-directory-p path)
(setq path (file-name-as-directory path))
|
@CeleritasCelery I've made a change to ivy.el with a recent commit, after that e.g. Please add the path expansion check as a new PR. |
Suppose an (ivy-read "test: " '("1" "2" "3")) is done when another `ivy-read' is in progress. In that case, after the first `ivy-read' returns a string, we should restore the state of the first `ivy-read'. Re abo-abo#1932
Closes #776. In that issue @Henry created some code to add environment variable completion to
counsel-find-file
. @abo-abo asked if he or @TauPan could make a PR. Since it has been several months, I took the opportunity to make a PR. I also simplified the code and made it more performant.