Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't bury killed buffers after counsel-switch-buffer #1959

Closed
wants to merge 1 commit into from

Conversation

@flatwhatson
Copy link
Contributor

@flatwhatson flatwhatson commented Mar 9, 2019

It's possible for a killed buffer to remain on buffer-list, causing bury-buffer to error while restoring the original buffer-list. Erroring here leaves counsel--switch-buffer-temporary-buffers and counsel--switch-buffer-previous-buffers set with old values, leading to abnormal behavior on subsequent calls to counsel-switch-buffer.

counsel.el Outdated Show resolved Hide resolved
It's possible for a killed buffer to remain on buffer-list, causing
bury-buffer to error while restoring the original buffer-list.
@flatwhatson flatwhatson force-pushed the fix-killed-buffer branch from 5396515 to 048d13b Mar 21, 2019
@flatwhatson
Copy link
Contributor Author

@flatwhatson flatwhatson commented Mar 21, 2019

@abo-abo Please let me know if you need anything else from me for this one.

@abo-abo abo-abo closed this in 456e575 Mar 25, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Mar 25, 2019

Thanks.

@flatwhatson flatwhatson deleted the fix-killed-buffer branch Mar 25, 2019
@flatwhatson
Copy link
Contributor Author

@flatwhatson flatwhatson commented Mar 25, 2019

Thanks ❤️

astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
It's possible for a killed buffer to remain on buffer-list, causing
bury-buffer to error while restoring the original buffer-list.

Fixes abo-abo#1959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants