New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various counsel-compile cleanups #1963
Closed
Closed
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5f4e944
counsel.el: Fix finding dominating file
basil-conto 072f238
counsel.el: Capitalize proper noun "Git"
basil-conto 876b4ac
counsel.el (counsel-compile): Minor cleanup
basil-conto adea72f
counsel.el: Simplify counsel-compile action
basil-conto 859e3cb
counsel.el: Clean up compile history keeping
basil-conto 8a40934
counsel.el: Clean up compile candidates list
basil-conto 0c30e3f
counsel.el: Minor compile history cleanup
basil-conto 1439e8d
counsel.el: Simplify compile build dir collection
basil-conto 50dc9e6
counsel.el (counsel--get-build-subdirs): Fix
basil-conto 4e0d403
counsel.el (counsel--find-build-subdir): Simplify
basil-conto 82e6c54
counsel.el: Clean up compile make invocation
basil-conto 7e8a362
counsel.el (counsel--get-make-targets): Clean up
basil-conto 144e7d9
counsel.el: Clean up recent compile variables
basil-conto 11487d3
counsel.el: Find project root more flexibly
basil-conto File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we should fix this. You could merge with c653867?