Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make find-file-occur work with multi-pass regex builders #1984

Closed

Conversation

@CeleritasCelery
Copy link
Contributor

@CeleritasCelery CeleritasCelery commented Mar 27, 2019

This is similar to #1973. Basically, find-file-occur and counsel-git-occur do not work with multi-pass regex builders. And even single pass regex builders do not respect ivy-use-ignore in occur buffers.

This PR requires more code then the buffer occur fix because we are relying on external processes. Alternatively, since dired supports taking a list of files, we could replace counsel-dired-occur and all related code with a much simpler builtin function. However, it is slow on large files sets, because each file requires its own subprocess.

This PR also prevents counsel--elisp-to-pcre from creating look-arounds when the regex is just a single positive form. This was requested by @abo-abo in #1976. Tests added as well.

Copy link
Collaborator

@basil-conto basil-conto left a comment

Thanks for working on this!

counsel.el Show resolved Hide resolved
counsel.el Outdated Show resolved Hide resolved
counsel.el Show resolved Hide resolved
counsel.el Show resolved Hide resolved
counsel.el Outdated Show resolved Hide resolved
counsel.el Outdated Show resolved Hide resolved
@abo-abo abo-abo closed this in 164fecb Mar 27, 2019
abo-abo added a commit that referenced this issue Mar 27, 2019
Don't use `and' for side effects.
Avoid overwriting `cmd' binding.

Re #1984
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Mar 27, 2019

Thanks.

astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Prevent pcre conversion from creating look-around for a single form

Fixes abo-abo#1984
astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Don't use `and' for side effects.
Avoid overwriting `cmd' binding.

Re abo-abo#1984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants