Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el (counsel-unicode-char): Fix sorting #1988

Closed
wants to merge 1 commit into from

Conversation

@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Mar 28, 2019

ivy--sort-function may return nil, but doing this is redundant anyway, since counsel--unicode-table is sorted and cached lazily, and ivy-read later obeys ivy-sort-functions-alist and ivy-sort-max-size.

Re: dc250bd

ivy--sort-function may return nil, but doing this is redundant
anyway, since counsel--unicode-table is sorted and cached lazily,
and ivy-read later obeys ivy-sort-functions-alist and
ivy-sort-max-size.
@abo-abo abo-abo closed this in ffa2d8f Mar 28, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Mar 28, 2019

Thanks.

@basil-conto basil-conto deleted the blc/unicode branch Mar 28, 2019
astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
ivy--sort-function may return nil, but doing this is redundant
anyway, since counsel--unicode-table is sorted and cached lazily,
and ivy-read later obeys ivy-sort-functions-alist and
ivy-sort-max-size.

Fixes abo-abo#1988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants