Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix counsel-org-tag-agenda #1997

Merged
merged 1 commit into from Apr 3, 2019
Merged

Fix counsel-org-tag-agenda #1997

merged 1 commit into from Apr 3, 2019

Conversation

@weirdNox
Copy link
Contributor

@weirdNox weirdNox commented Apr 3, 2019

As of Org 9.2.3, this function is not working because org-set-tags is the function that received the tags list or string, while the counsel substitute doesn't have any parameters.

Changing this to org-set-tags-command, which is called from org-agenda-set-tags fixes the issue.

As of Org 9.2.3, this function is not working because `org-set-tags` is the function that received the tags list or string, while the counsel substitute doesn't have any parameters.

Changing this to `org-set-tags-command`, which is called from `org-agenda-set-tags` fixes the issue.
@abo-abo abo-abo merged commit 5e54abd into abo-abo:master Apr 3, 2019
1 check passed
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Apr 3, 2019

Thanks, please review my follow up commit.

@weirdNox
Copy link
Contributor Author

@weirdNox weirdNox commented Apr 3, 2019

Works great, I forgot about keeping backwards compatibility as this was a change on my personal config :P
Thanks!

basil-conto added a commit to basil-conto/swiper that referenced this issue Apr 6, 2019
(counsel-org-tag-agenda): Use the variable, not interactive
function, named org-version.  Simplify with cl-letf.

Re: abo-abo#1997
abo-abo added a commit that referenced this issue Apr 6, 2019
(counsel-org-tag-agenda): Use the variable, not interactive
function, named org-version.  Simplify with cl-letf.

Fixes #2006
Re: #1997
astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
(counsel-org-tag-agenda): Use the variable, not interactive
function, named org-version.  Simplify with cl-letf.

Fixes abo-abo#2006
Re: abo-abo#1997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants