Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counsel-minor command #2000

Closed
wants to merge 1 commit into from
Closed

Add counsel-minor command #2000

wants to merge 1 commit into from

Conversation

@iquiw
Copy link
Contributor

@iquiw iquiw commented Apr 4, 2019

Fixes #1987

The test defines some dummy variables and commands. Please omit the commit if you think it is not appropriate.

Like counsel-package, disabled minor modes are prefixed with "+" and
enabled minor modes are prefixed with "-".
By selecting one of them, the mode is called interactively. As a result,
toggle the minor mode enability.
@iquiw
Copy link
Contributor Author

@iquiw iquiw commented Apr 4, 2019

hmm, the test failed. I will check.

@iquiw
Copy link
Contributor Author

@iquiw iquiw commented Apr 4, 2019

I suppose format-mode-line produces empty string when running with emacs --batch.
I will remove the test as I have no idea how to solve.

@iquiw iquiw force-pushed the counsel-minor branch from 29e5ccb to 54658b8 Apr 4, 2019
@iquiw
Copy link
Contributor Author

@iquiw iquiw commented Apr 4, 2019

I will remove the test as I have no idea how to solve.

Removed.

@abo-abo abo-abo closed this in 1e38ed4 Apr 4, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Apr 4, 2019

Thanks, well done. And congrats on getting #2000 :)

@iquiw iquiw deleted the counsel-minor branch Apr 5, 2019
astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Like counsel-package, disabled minor modes are prefixed with "+" and
enabled minor modes are prefixed with "-".
By selecting one of them, the mode is called interactively. As a result,
toggle the minor mode enability.

Fixes abo-abo#2000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants