Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for swiper-isearch #2029

Closed
wants to merge 4 commits into from

Conversation

@flatwhatson
Copy link
Contributor

@flatwhatson flatwhatson commented Apr 15, 2019

Adds swiper-goto-start-of-match support for swiper-isearch.

Adds swiper-isearch-map with C-s and C-r bindings, matching the isearch bindings for continuing/reversing the search.

Adds a call to swiper-font-lock-ensure to prevent showing unformatted candidates.

Fixes #2025 by always keeping the exact start point in swiper--isearch-point-history.

@manuel-uberti
Copy link
Contributor

@manuel-uberti manuel-uberti commented Apr 16, 2019

Does this PR address #2025?

@flatwhatson
Copy link
Contributor Author

@flatwhatson flatwhatson commented Apr 16, 2019

It doesn't.

@flatwhatson
Copy link
Contributor Author

@flatwhatson flatwhatson commented Apr 16, 2019

@manuel-uberti Please try the latest commit.

@manuel-uberti
Copy link
Contributor

@manuel-uberti manuel-uberti commented Apr 16, 2019

@flatwhatson Works as expected, thanks.

@flatwhatson flatwhatson changed the title Small improvements for swiper-isearch Improvements for swiper-isearch Apr 16, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented May 7, 2019

Thanks. I'm merging the original commit, but not the rest.

Add some isearch keys

I don't want to modify C-r, the consistent ivy-reverse-i-search across all commands is important: hitting M-p many times while looking for something is a bad pattern, and C-r aims to fix that.

And C-s is already there.

Ensure buffer is font-locked

I've avoided this on purpose for swiper-isearch. The point is to have as short start-up time as possible.

Keep exact starting position

Here you remove the executing-kbd-macro logic, which was added on purpose to make swiper-isearch usable when defining macros. Let's try to fix the referenced issue while keeping the macro-defining functionality.

@abo-abo abo-abo closed this in f1b3fa4 May 7, 2019
abo-abo added a commit that referenced this issue May 7, 2019
@flatwhatson
Copy link
Contributor Author

@flatwhatson flatwhatson commented May 8, 2019

Thanks! <3

@flatwhatson flatwhatson deleted the swiper-isearch branch May 8, 2019
astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants