Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el (counsel-recentf): Require match #2043

Closed
wants to merge 1 commit into from

Conversation

@amosbird
Copy link
Contributor

@amosbird amosbird commented Apr 28, 2019

or else Wrong type argument: stringp, nil

or else `Wrong type argument: stringp, nil`
@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Apr 28, 2019

Where does the error come from? Can you please M-xtoggle-debug-on-errorRET and paste the error backtrace?

Also, the current PR title and commit message do not make it clear what the purpose of the commit is. Can you please retitle the PR and rewrite the commit message so that they convey more information? Even something like "counsel.el (counsel-recentf): Require match" would be more informative than "Update counsel.el".

@amosbird
Copy link
Contributor Author

@amosbird amosbird commented Apr 28, 2019

hmm, actually that error comes from my local find-file advice, or a new file gets created. However I think require-match for recentf still makes sense.

@amosbird amosbird changed the title Update counsel.el counsel.el (counsel-recentf): Require match Apr 28, 2019
@amosbird
Copy link
Contributor Author

@amosbird amosbird commented Apr 28, 2019

Anyway, I'll close this. Not an issue.

@amosbird amosbird closed this Apr 28, 2019
@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Apr 28, 2019

However I think require-match for recentf still makes sense.

I agree.

@amosbird amosbird deleted the patch-3 branch Apr 28, 2019
abo-abo added a commit that referenced this issue May 6, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented May 6, 2019

@amosbird Thanks, added.

astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants