Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview and highlight to `counsel-mark-ring' #2078

Closed
wants to merge 2 commits into from

Conversation

@yonta
Copy link
Contributor

@yonta yonta commented May 24, 2019

The counsel-mark-ring' don't have preview and highlight by candidate. These functions like swiper' are also useful in `counsel-mark-ring'.

image

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented May 25, 2019

Thanks. Do you have an Emacs CA?

@yonta
Copy link
Contributor Author

@yonta yonta commented May 26, 2019

Oops, I have missed copyright assignment in CONTRIBUTING.org.
I'm starting to request Emacs CA.👍
Please, wait for while.

@yonta
Copy link
Contributor Author

@yonta yonta commented Jun 20, 2019

I did it!
I have received Emacs CA signed by FSF.
Should I show some evidence?

@abo-abo abo-abo closed this in 94f107b Jun 22, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 22, 2019

Thanks, I see you on the copyright.list file. Good job, merged.

@yonta yonta deleted the pr-mark-ring-preview branch Aug 20, 2019
astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants