Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.el (ivy--highlight-default): Fuzzy highlight improvements #2080

Closed
wants to merge 2 commits into from

Conversation

flatwhatson
Copy link
Contributor

Fix a bug where unmatched subexpressions would cause highlighting to abort early. This can happen when the regex has a branch, for example.

Use a single face for adjacent subexpression matches. This makes the highlighting of fuzzy matches a bit easier to parse visually.

It's possible for a regex to have subexpressions which aren't matched,
and therefore have a nil beginning and end. These were raising an error
which aborted the highlight pass before it was finished.
This improves highlighting for fuzzy matches by using a single face for
adjacent groups.
@abo-abo abo-abo closed this in 0134255 May 27, 2019
@abo-abo
Copy link
Owner

abo-abo commented May 27, 2019

Merged, thanks.

@flatwhatson
Copy link
Contributor Author

Thanks <3

@flatwhatson flatwhatson deleted the better-hilite branch May 27, 2019 23:57
abo-abo pushed a commit that referenced this pull request Nov 10, 2020
astoff pushed a commit to astoff/swiper that referenced this pull request Jan 1, 2021
This improves highlighting for fuzzy matches by using a single face for
adjacent groups.

Fixes abo-abo#2080
astoff pushed a commit to astoff/swiper that referenced this pull request Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants