Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swiper-isearch breaks ivy-resume #2084

Closed
wants to merge 1 commit into from
Closed

Conversation

@amosbird
Copy link
Contributor

@amosbird amosbird commented May 29, 2019

#2083

(let ((default-directory (ivy-state-directory ivy-last))
(ivy-format-function (if (eq (ivy-state-caller ivy-last) 'swiper-isearch)
#'swiper-isearch-format-function
#'ivy-format-function)))
Copy link
Collaborator

@basil-conto basil-conto May 29, 2019

Is there no other way to avoid hard-coding this?

@amosbird
Copy link
Contributor Author

@amosbird amosbird commented May 30, 2019

There is also a case for `swiper' too.

@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented May 30, 2019

There is also a case for `swiper' too.

WDYM? Why shouldn't we look for better alternatives to adding more hard-coded collection checks?

@abo-abo abo-abo closed this in 7feb14f Jun 3, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 3, 2019

Thanks, all. I went with a generic solution that introduces ivy-format-functions-alist and makes ivy-format-function.

Please review and test if it fixes the issue.

@manuel-uberti
Copy link
Contributor

@manuel-uberti manuel-uberti commented Jun 3, 2019

I can resume a swiper-isearch now. Thanks.

astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants