Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ivy-display-function: obsolete this varible in favor ivy-display-functions-alist #2089

Merged
merged 1 commit into from
Jun 5, 2019
Merged

ivy-display-function: obsolete this varible in favor ivy-display-functions-alist #2089

merged 1 commit into from
Jun 5, 2019

Conversation

tumashu
Copy link
Contributor

@tumashu tumashu commented Jun 5, 2019 •
edited
Loading

  • ivy.el (ivy-display-function): make-obsolete ivy-display-function variable.
    (ivy--display-function): new variable.
    (ivy-display-functions-alist): defvar -> defcustom.
    (ivy-read, ivy--display-function-prop, ivy--insert-minibuffer): use ivy--display-function instead.

@tumashu tumashu changed the title ivy-display-function: obsolete this varible in favor ivy-display-func… ivy-display-function: obsolete this varible in favor ivy-display-function Jun 5, 2019
@tumashu
ivy-display-function: obsolete this varible in favor ivy-display-func…
f40b08a 
…tions-alist

* ivy.el (ivy-display-function): make-obsolete ivy-display-function variable.
(ivy--display-function): new variable.
(ivy-display-functions-alist): defvar -> defcustom.
(ivy-read, ivy--display-function-prop, ivy--insert-minibuffer): use ivy--display-function instead.
@tumashu
Copy link
Contributor Author

tumashu commented Jun 5, 2019

ivy-display-functions-alist is more powful than ivy-display-function, one custom is enough :-)
Similar:

(defvar ivy-format-function #'ivy-format-function-default
  "Function to transform the list of candidates into a string.
This string is inserted into the minibuffer.")

(make-obsolete-variable
 'ivy-format-function 'ivy-format-functions-alist "<2019-06-03 Mon>")

@tumashu tumashu changed the title ivy-display-function: obsolete this varible in favor ivy-display-function ivy-display-function: obsolete this varible in favor ivy-display-functions-alist Jun 5, 2019
@abo-abo abo-abo merged commit f40b08a into abo-abo:master Jun 5, 2019
abo-abo added a commit that referenced this pull request Jun 5, 2019
@abo-abo
ivy.el (ivy-read): Don't use ivy-display-function
ef1e8d5 
Use `ivy-display-functions-alist' instead.

Re #2089
@abo-abo
Copy link
Owner

abo-abo commented Jun 5, 2019

Thanks.

astoff pushed a commit to astoff/swiper that referenced this pull request Jan 1, 2021
@abo-abo @astoff
ivy.el (ivy-read): Don't use ivy-display-function
27dd7c3 
Use `ivy-display-functions-alist' instead.

Re abo-abo#2089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tumashu @abo-abo