* ivy.el (ivy--find-file-action): Fix for virtual buffers #2111
thanks for telling me. In this case, I think we should also fix
(defun counsel-open-buffer-file-externally (buffer) "Open the file associated with BUFFER with an external program." (when (zerop (length buffer)) (user-error "Can't open that")) (let* ((virtual (assoc buffer ivy--virtual-buffers)) (filename (if virtual buffer (buffer-file-name (get-buffer buffer))))) (unless filename (user-error "Can't open `%s' externally" buffer)) (counsel-locate-action-extern (expand-file-name filename))))
If you agree I will send a PR.
DamienCassou added a commit to DamienCassou/swiper that referenced this issue
Jun 29, 2019
According to abo-abo#2111, it's better to use `(cdr virtual)` than `buffer`.
astoff added a commit to astoff/swiper that referenced this issue
Jan 1, 2021
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.