Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add {swiper,counsel-grep,consel-grep-or-swiper}-backward commands #2132

Closed
wants to merge 2 commits into from

Conversation

@jrosdahl
Copy link
Contributor

@jrosdahl jrosdahl commented Jul 13, 2019

Implements and closes #1172, with counsel-grep-backward and counsel-grep-or-swiper-backward commands as a bonus. Just tell me if you want me to separate these into separate PRs or if you're not interested in some of the commands.

Side notes:

  • I wrote the above mentioned commands 5-6 months ago and intended to create a PR after completing the FSF copyright assignment procedure. It turned out to take quite some time to get a signed disclaimer from the company I work for, but it's finally finished now.
  • Regarding #2125 ("Add swiper-isearch-backward"), it looks like it won't be possible to use the same approach for that command as for swiper-backward since the implementations of swiper and swiper-isearch seem quite different.
@andschwa
Copy link
Contributor

@andschwa andschwa commented Jul 13, 2019

What did you think about renaming the original commands with -forward suffixes for symmetry?

@jrosdahl
Copy link
Contributor Author

@jrosdahl jrosdahl commented Jul 14, 2019

What did you think about renaming the original commands with -forward suffixes for symmetry?

Sounds OK to have aliases for symmetry, but I guess renaming won't fly since that would break people's configs.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jul 16, 2019

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants