Make nonexistent parent dirs in counsel-find-file-mkdir-action #2178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Currently if you dispatch the
mkdir
action fromcounsel-find-file
with input (ivy-text
, I think?) "multi/level/dirs", it will fail inmake-directory
because "multi" (relative to the default directory) doesn't exist. I think the intent in such a case would to make the all the directories and this change enables that by passing a non-nil optional argumentPARENTS
tomake-directory
.Since this is such a small change, I don't think I need to worry about the copyright assignment and there doesn't seem to be any difference between my branch and master for the
make
checks.I have an ERT test I can add too, but it feels a little weird since it involves modifying the filesystem and then cleaning up the changes.