Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nonexistent parent dirs in counsel-find-file-mkdir-action #2178

Merged
merged 1 commit into from Jul 31, 2019

Conversation

dmringo
Copy link
Contributor

@dmringo dmringo commented Jul 31, 2019

Currently if you dispatch the mkdir action from counsel-find-file with input (ivy-text, I think?) "multi/level/dirs", it will fail in make-directory because "multi" (relative to the default directory) doesn't exist. I think the intent in such a case would to make the all the directories and this change enables that by passing a non-nil optional argument PARENTS to make-directory.

Since this is such a small change, I don't think I need to worry about the copyright assignment and there doesn't seem to be any difference between my branch and master for the make checks.

I have an ERT test I can add too, but it feels a little weird since it involves modifying the filesystem and then cleaning up the changes.

@abo-abo abo-abo merged commit 2db2c51 into abo-abo:master Jul 31, 2019
1 check passed
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jul 31, 2019

Thanks.

@dmringo dmringo deleted the counsel-mkdir-parent branch Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants