Skip to content

Save use-ignore setting on ivy-resume #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

CeleritasCelery
Copy link
Contributor

@CeleritasCelery CeleritasCelery commented Aug 1, 2019

Currently ivy-resume does not respect ivy-use-ignore. If you toggle the ignore setting, then quit the ivy session and try to resume, it will reset to ivy-use-ignore-default. This PR will save the use-ignore setting with the state, so it will be resumed as expected.

@abo-abo
Copy link
Owner

abo-abo commented Aug 1, 2019

Thanks. But could you please re-work it a little? Instead of adding a new argument to ivy-read, we can just let-bind ivy-use-ignore-default in ivy-resume. Exactly how we do it with default-directory.

@CeleritasCelery
Copy link
Contributor Author

Good feedback that simplified this change. Let me know what you think.

@abo-abo abo-abo merged commit 44c4bab into abo-abo:master Aug 2, 2019
@abo-abo
Copy link
Owner

abo-abo commented Aug 2, 2019

Thanks. Looks like we can deprecate ivy-use-ignore, since (ivy-state-ignore ivy-last) now stores the same value.

@CeleritasCelery
Copy link
Contributor Author

CeleritasCelery commented Aug 2, 2019

I thought about doing that, but I saw that some counsel functions were using ivy-use-ignore and assumed that other external functions may as well.

@abo-abo
Copy link
Owner

abo-abo commented Aug 3, 2019

Yes, I noticed that as well. I try to adhere to a deprecation workflow:

;; git shows it's deprecated on 2018-10-11
(define-obsolete-variable-alias 'counsel-more-chars-alist 'ivy-more-chars-alist "0.10.0")

After deprecation, using this variable either in config or a package results in a warning. So I think it's fine to remove even the deprecated alias after a year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants