Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.el read-directory-name: fix parent dirs #2198

Closed
wants to merge 1 commit into from

Conversation

muirdm
Copy link
Contributor

@muirdm muirdm commented Aug 13, 2019

When selecting a directory, if you removed elements from the default
directory (e.g. by pressing DEL) and then used ivy-immediate-done, you
were getting back the starting directory instead of the ancestor
directory.

Fixes #2165

When selecting a directory, if you removed elements from the default
directory (e.g. by pressing DEL) and then used ivy-immediate-done, you
were getting back the starting directory instead of the ancestor
directory.

Fixes abo-abo#2165
@abo-abo abo-abo closed this in e41cbec Aug 21, 2019
@abo-abo
Copy link
Owner

abo-abo commented Aug 21, 2019

Thanks, I've merged it with a fix, since the tests were failing. Please review.

astoff pushed a commit to astoff/swiper that referenced this pull request Jan 1, 2021
When selecting a directory, if you removed elements from the default
directory (e.g. by pressing DEL) and then used ivy-immediate-done, you
were getting back the starting directory instead of the ancestor
directory.

Fixes abo-abo#2165
Fixes abo-abo#2198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"ivy-immediate-done" returning empty string
2 participants