Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ivy--magic-file-slash less aggressive #2240

Closed
wants to merge 1 commit into from

Conversation

m-plamann
Copy link
Contributor

@m-plamann m-plamann commented Sep 19, 2019

In counsel-find-file, when the user types "foo", selects the prompt, and
presses "/", the result should be "foo/".

If the directory "foobar" exists, but "foo" does not, typing "foo",
selecting the prompt, and pressing "/" results in "cd"ing to "foobar"
(assuming ivy-magic-slash-non-match-action is
'ivy-magic-slash-non-match-cd-selected). This commit changes
ivy--magic-file-slash to check that the prompt is not selected before
performing the ivy-magic-slash-non-match-cd-selected action.

In counsel-find-file, when the user types "foo", selects the prompt, and
presses "/", the result should be "foo/".

If the directory "foobar" exists, but "foo" does not, typing "foo",
selecting the prompt, and pressing "/" results in "cd"ing to "foobar"
(assuming ivy-magic-slash-non-match-action is
'ivy-magic-slash-non-match-cd-selected). This commit changes
ivy--magic-file-slash to check that the prompt is not selected before
performing the ivy-magic-slash-non-match-cd-selected action.
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 8, 2019

Thanks, merged.

astoff pushed a commit to astoff/swiper that referenced this issue Jan 1, 2021
In counsel-find-file, when the user types "foo", selects the prompt, and
presses "/", the result should be "foo/".

If the directory "foobar" exists, but "foo" does not, typing "foo",
selecting the prompt, and pressing "/" results in "cd"ing to "foobar"
(assuming ivy-magic-slash-non-match-action is
'ivy-magic-slash-non-match-cd-selected). This commit changes
ivy--magic-file-slash to check that the prompt is not selected before
performing the ivy-magic-slash-non-match-cd-selected action.

Fixes abo-abo#2240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants