Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counsel compile/next #2253

Merged
merged 2 commits into from Oct 2, 2019
Merged

Counsel compile/next #2253

merged 2 commits into from Oct 2, 2019

Conversation

stsquad
Copy link
Contributor

@stsquad stsquad commented Oct 1, 2019

Just a couple of minor fixes. I'd still like to find an elegant fix for #2040 but no need to hold up these fixes for that.

stsquad added 2 commits Oct 1, 2019
The counsel-compile--current-build-dir variable is set if we ever
descend into a build directory. However sometimes the user might want
to build in the top level, for example QEMU's docker build targets are
independent of configured builds. In this case default-directory is a
poor choice if you are calling from a file somewhere deep in the
source tree, especially as we have a function to find the root.
@abo-abo abo-abo merged commit 47f6427 into abo-abo:master Oct 2, 2019
1 check passed
@abo-abo
Copy link
Owner

abo-abo commented Oct 2, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants