Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el (counsel-mark-ring): Add customize variable to sort or not #2254

Merged
merged 1 commit into from Oct 3, 2019

Conversation

yonta
Copy link
Contributor

@yonta yonta commented Oct 3, 2019

Now, counsel-mark-ring sorts selections of mark-ring.
But, I think that the order of the mark-ring is meaningful for users.
This change gives users to choice sort or not by new custom variable.

@abo-abo abo-abo merged commit 46db1b9 into abo-abo:master Oct 3, 2019
1 check passed
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 3, 2019

Thanks. Please also review my follow-up commit.

I think it would also be nice for C-k in counsel-mark-ring to function the same as ivy-switch-buffer-kill. Just a note for the future :)

@yonta
Copy link
Contributor Author

@yonta yonta commented Oct 3, 2019

So Great!!
I really wanted this feature, but I can not implement.
Thanks.

And, your idea about "C-k" in counsel-mark-ring sounds nice.👍

@yonta yonta deleted the mark-ring-custom-sort branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants