Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix counsel-cd' for counsel-ag' and `counsel-git-grep' #2261

Closed
wants to merge 1 commit into from

Conversation

xuhdev
Copy link
Contributor

@xuhdev xuhdev commented Oct 6, 2019

  • counsel.el (counsel-git-grep-map, counsel-git-grep)
    (counsel-ag-map, counsel-cd-ag, counsel-cd-git-grep): Fix (completely
    broken) counsel-cd' for counsel-git-grep' and `counsel-ag'.

Turns out #2259 wasn't a proper patch (and counsel-cd' is not working for counsel-ag' as well).

* counsel.el (counsel-git-grep-map, counsel-git-grep)
(counsel-ag-map, counsel-cd-ag, counsel-cd-git-grep): Fix (completely
broken) `counsel-cd' for `counsel-git-grep' and `counsel-ag'.
abo-abo pushed a commit that referenced this issue Oct 7, 2019
Fix (completely broken) `counsel-cd' for `counsel-ag'.

Re #2261
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 7, 2019

Thanks. Please review the follow up commit and test.

@xuhdev xuhdev deleted the counsel-cd branch Oct 7, 2019
@xuhdev
Copy link
Contributor Author

@xuhdev xuhdev commented Oct 7, 2019

Yes, it works. Thanks!

astoff pushed a commit to astoff/swiper that referenced this issue Jan 1, 2021
Fix (completely broken) `counsel-cd' for `counsel-ag'.

Re abo-abo#2261
astoff pushed a commit to astoff/swiper that referenced this issue Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants