Fix counsel-cd' for counsel-ag' and `counsel-git-grep'
#2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* counsel.el (counsel-git-grep-map, counsel-git-grep) (counsel-ag-map, counsel-cd-ag, counsel-cd-git-grep): Fix (completely broken) `counsel-cd' for `counsel-git-grep' and `counsel-ag'.
abo-abo
pushed a commit
that referenced
this pull request
Oct 7, 2019
Fix (completely broken) `counsel-cd' for `counsel-ag'. Re #2261
|
Thanks. Please review the follow up commit and test. |
|
Yes, it works. Thanks! |
astoff
pushed a commit
to astoff/swiper
that referenced
this pull request
Jan 1, 2021
Fix (completely broken) `counsel-cd' for `counsel-ag'. Re abo-abo#2261
astoff
pushed a commit
to astoff/swiper
that referenced
this pull request
Jan 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(counsel-ag-map, counsel-cd-ag, counsel-cd-git-grep): Fix (completely
broken)
counsel-cd' forcounsel-git-grep' and `counsel-ag'.Turns out #2259 wasn't a proper patch (and
counsel-cd' is not working forcounsel-ag' as well).