Allow counsel-find-file to accept file type limitation. #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow `counsel-find-file' to accept a file with its type limited to regular files or directories. This, for example, can be used to limit the scope of `counsel-dired' within directories. It also enables more features in ivy in a directory selector in the future than `read-directory-name' (e.g., abo-abo#1646).
|
Thanks. Do you have an Emacs CA? |
|
Yes. Couldn't find the exact proof, but the amount of my contribution to Emacs should be able to prove that (exceeded the legal significance threshold). |
|
Thanks. I see your email on I rewrote your commit to simplify things a bit. Please review. |
|
Looks good to me. Thanks! |
astoff
pushed a commit
to astoff/swiper
that referenced
this pull request
Jan 1, 2021
Allow `counsel-find-file' to accept a file with its type limited to regular files or directories. It also enables more features in ivy in a directory selector in the future than `read-directory-name' (e.g., abo-abo#1646). Fixes abo-abo#2275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow counsel-find-file to accept a file with its type limited to
regular files or directories.
This, for example, can be used to limit the scope of counsel-dired
within directories. It also enables more features in ivy in a directory
selector in the future than read-directory-name (e.g., #1646).