Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow counsel-find-file to accept file type limitation. #2275

Closed
wants to merge 1 commit into from

Conversation

xuhdev
Copy link
Contributor

@xuhdev xuhdev commented Oct 14, 2019

Allow counsel-find-file to accept a file with its type limited to
regular files or directories.

This, for example, can be used to limit the scope of counsel-dired
within directories. It also enables more features in ivy in a directory
selector in the future than read-directory-name (e.g., #1646).

Allow `counsel-find-file' to accept a file with its type limited to
regular files or directories.

This, for example, can be used to limit the scope of `counsel-dired'
within directories. It also enables more features in ivy in a directory
selector in the future than `read-directory-name' (e.g., abo-abo#1646).
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 14, 2019

Thanks. Do you have an Emacs CA?

@xuhdev
Copy link
Contributor Author

@xuhdev xuhdev commented Oct 14, 2019

Yes. Couldn't find the exact proof, but the amount of my contribution to Emacs should be able to prove that (exceeded the legal significance threshold).

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 14, 2019

Thanks. I see your email on copyright.list.

I rewrote your commit to simplify things a bit. Please review.

@xuhdev
Copy link
Contributor Author

@xuhdev xuhdev commented Oct 14, 2019

Looks good to me. Thanks!

@xuhdev xuhdev deleted the find-file-type branch Oct 17, 2019
astoff pushed a commit to astoff/swiper that referenced this issue Jan 1, 2021
Allow `counsel-find-file' to accept a file with its type limited to
regular files or directories.

It also enables more features in ivy in a directory selector in the
future than `read-directory-name' (e.g., abo-abo#1646).

Fixes abo-abo#2275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants