Make ivy-completing-read handle history as cons #295
Closed
Conversation
The ivy-read function assumes that history is a symbol, hence ivy-completing-read now makes sure that a symbol is given to ivy-read. Moreover, it makes sure that the value of initial-input is coherent with the value of the HISTPOS part of the history variable if it exists.
|
Thanks! I've simplified the code a bit. |
|
Thank you for ivy :-). I've come a long way from ido, icicles, helm and now ivy and hope to finally find a tool that fits well with my way of thinking. |
abo-abo
added a commit
that referenced
this pull request
Nov 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The ivy-read function assumes that history is a symbol, hence
ivy-completing-read now makes sure that a symbol is given to
ivy-read.
Moreover, it makes sure that the value of initial-input is
coherent with the value of the HISTPOS part of the history
variable if it exists.