New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ivy-completing-read handle history as cons #295

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Konubinix
Contributor

Konubinix commented Nov 18, 2015

The ivy-read function assumes that history is a symbol, hence
ivy-completing-read now makes sure that a symbol is given to
ivy-read.

Moreover, it makes sure that the value of initial-input is
coherent with the value of the HISTPOS part of the history
variable if it exists.

Make ivy-completing-read handle history as cons
The ivy-read function assumes that history is a symbol, hence
ivy-completing-read now makes sure that a symbol is given to
ivy-read.

Moreover, it makes sure that the value of initial-input is
coherent with the value of the HISTPOS part of the history
variable if it exists.

@abo-abo abo-abo closed this in adac116 Nov 18, 2015

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Nov 18, 2015

Owner

Thanks! I've simplified the code a bit.

Owner

abo-abo commented Nov 18, 2015

Thanks! I've simplified the code a bit.

@Konubinix

This comment has been minimized.

Show comment
Hide comment
@Konubinix

Konubinix Nov 18, 2015

Contributor

Thank you for ivy :-). I've come a long way from ido, icicles, helm and now ivy and hope to finally find a tool that fits well with my way of thinking.

Contributor

Konubinix commented Nov 18, 2015

Thank you for ivy :-). I've come a long way from ido, icicles, helm and now ivy and hope to finally find a tool that fits well with my way of thinking.

abo-abo added a commit that referenced this pull request Nov 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment