Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMake ivy-completing-read handle history as cons #295
Conversation
abo-abo
closed this
in
adac116
Nov 18, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Thanks! I've simplified the code a bit. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
Konubinix
Nov 18, 2015
Contributor
Thank you for ivy :-). I've come a long way from ido, icicles, helm and now ivy and hope to finally find a tool that fits well with my way of thinking.
|
Thank you for ivy :-). I've come a long way from ido, icicles, helm and now ivy and hope to finally find a tool that fits well with my way of thinking. |
added a commit
that referenced
this pull request
Nov 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Konubinix commentedNov 18, 2015
The ivy-read function assumes that history is a symbol, hence
ivy-completing-read now makes sure that a symbol is given to
ivy-read.
Moreover, it makes sure that the value of initial-input is
coherent with the value of the HISTPOS part of the history
variable if it exists.