New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ivy--regex-plus recognize ! at the beginning of the str #318

Merged
merged 1 commit into from Dec 9, 2015

Conversation

Projects
None yet
2 participants
@Konubinix
Contributor

Konubinix commented Dec 9, 2015

When one types '!foo, he expects the candidates to be filtered out
by 'foo'.

Make ivy--regex-plus recognize ! at the beginning of the str
When one types '!foo, he expects the candidates to be filtered out
by 'foo'.
@Konubinix

This comment has been minimized.

Show comment
Hide comment
@Konubinix

Konubinix Dec 9, 2015

Contributor

In order to test this behavior, you can run

(completing-read ">" '("foo" "bar"))

If you type "!foo", the only remaining candidate will be "foo".

With the patch, the only remaining candidate will be "bar"

Contributor

Konubinix commented Dec 9, 2015

In order to test this behavior, you can run

(completing-read ">" '("foo" "bar"))

If you type "!foo", the only remaining candidate will be "foo".

With the patch, the only remaining candidate will be "bar"

@abo-abo abo-abo merged commit 6951eba into abo-abo:master Dec 9, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Dec 9, 2015

Owner

Thanks.

Owner

abo-abo commented Dec 9, 2015

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment