Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy: fix ivy--resize-minibuffer-to-fit for small delta #339

Merged
merged 1 commit into from Jan 7, 2016

Conversation

@fjl
Copy link
Contributor

@fjl fjl commented Jan 6, 2016

Very small size increments can be necessary if the initial candidate
list is short (e.g. 3 items) and line-height is set to something other
than zero. In that case, only half of the last line is initially visible.
ivy--resize-minibuffer-to-fit recognizes this and tries to enlarge the
window up the the exact pixel height required, however window-resize
doesn't do anything if the delta is below frame-char-height.

Before:

before

After:

after

Very small size increments can be necessary if the initial candidate
list is short (e.g. 3 items) and line-height is set to something other
than zero. In that case, only half of the last line is initially
visible. ivy--resize-minibuffer-to-fit recognizes this and tries to
enlarge the window up the the exact pixel height required, however
window-resize doesn't do anything if the delta is below
frame-char-height.
@fjl fjl force-pushed the fjl:fix-resize-to-fit branch to 09cb5c9 Jan 6, 2016
@abo-abo abo-abo merged commit 09cb5c9 into abo-abo:master Jan 7, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jan 7, 2016

Thanks. Please note that you've reached the 15 lines contribution limit with this commit.
If you'd like to contribute more in the future, you'll need an Emacs Copyright Assignment (see).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.