New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ivy-fixed-height-minibuffer #353

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@justbur
Contributor

justbur commented Jan 17, 2016

This option attempts to make the minibuffer stay at a fixed height
regardless of the number of candidates. Some people prefer this as
it can be annoying when quickly going through folders of different
sizes for example.

Ref syl20bnr/spacemacs#4540 (comment)

Add ivy-fixed-height-minibuffer
This option attempts to make the minibuffer stay at a fixed height
regardless of the number of candidates. Some people prefer this as
it can be annoying when quickly going through folders of different
sizes for example
@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Jan 17, 2016

Owner

Thanks. The change looks OK (maybe name ivy-fixed-minibuffer-height). But you'll need to be on the Emacs Copyright Assignment list before I can merge this contribution.

Owner

abo-abo commented Jan 17, 2016

Thanks. The change looks OK (maybe name ivy-fixed-minibuffer-height). But you'll need to be on the Emacs Copyright Assignment list before I can merge this contribution.

@justbur

This comment has been minimized.

Show comment
Hide comment
@justbur

justbur Jan 17, 2016

Contributor

Ok how do I do that?
On Sun, Jan 17, 2016 at 4:07 PM Oleh Krehel notifications@github.com
wrote:

Thanks. The change looks OK (maybe name ivy-fixed-minibuffer-height). But
you'll need to be on the Emacs Copyright Assignment list before I can merge
this contribution.


Reply to this email directly or view it on GitHub
#353 (comment).

Contributor

justbur commented Jan 17, 2016

Ok how do I do that?
On Sun, Jan 17, 2016 at 4:07 PM Oleh Krehel notifications@github.com
wrote:

Thanks. The change looks OK (maybe name ivy-fixed-minibuffer-height). But
you'll need to be on the Emacs Copyright Assignment list before I can merge
this contribution.


Reply to this email directly or view it on GitHub
#353 (comment).

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Jan 17, 2016

Owner

Use this (self-explanatory) form: http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.future. The whole process can take a while (around a month) due to snail mail time, unless you live in US.

Owner

abo-abo commented Jan 17, 2016

Use this (self-explanatory) form: http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.future. The whole process can take a while (around a month) due to snail mail time, unless you live in US.

@justbur

This comment has been minimized.

Show comment
Hide comment
@justbur

justbur Jan 17, 2016

Contributor

Thanks. I'm not sure what to put for the package question. Should it be
swiper? Or swiper and counsel if I want to contribute to both? I'm assuming
ivy is not a package in this sense.

On Sun, Jan 17, 2016 at 4:21 PM Oleh Krehel notifications@github.com
wrote:

Use this (self-explanatory) form:
http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.future.
The whole process can take a while (around a month) due to snail mail time,
unless you live in US.


Reply to this email directly or view it on GitHub
#353 (comment).

Contributor

justbur commented Jan 17, 2016

Thanks. I'm not sure what to put for the package question. Should it be
swiper? Or swiper and counsel if I want to contribute to both? I'm assuming
ivy is not a package in this sense.

On Sun, Jan 17, 2016 at 4:21 PM Oleh Krehel notifications@github.com
wrote:

Use this (self-explanatory) form:
http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.future.
The whole process can take a while (around a month) due to snail mail time,
unless you live in US.


Reply to this email directly or view it on GitHub
#353 (comment).

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Jan 17, 2016

Owner

Just put "Emacs" in that category. You'll be able to contribute to org-mode, core Emacs, and any package in GNU ELPA (including swiper). I got my assignment for org-mode originally, but I've used it for everything since.

Owner

abo-abo commented Jan 17, 2016

Just put "Emacs" in that category. You'll be able to contribute to org-mode, core Emacs, and any package in GNU ELPA (including swiper). I got my assignment for org-mode originally, but I've used it for everything since.

@justbur

This comment has been minimized.

Show comment
Hide comment
@justbur

justbur Jan 17, 2016

Contributor

Oh great thank you.
On Sun, Jan 17, 2016 at 4:47 PM Oleh Krehel notifications@github.com
wrote:

Just put "Emacs" in that category. You'll be able to contribute to
org-mode, core Emacs, and any package in GNU ELPA (including swiper). I got
my assignment for org-mode originally, but I've used it for everything
since.


Reply to this email directly or view it on GitHub
#353 (comment).

Contributor

justbur commented Jan 17, 2016

Oh great thank you.
On Sun, Jan 17, 2016 at 4:47 PM Oleh Krehel notifications@github.com
wrote:

Just put "Emacs" in that category. You'll be able to contribute to
org-mode, core Emacs, and any package in GNU ELPA (including swiper). I got
my assignment for org-mode originally, but I've used it for everything
since.


Reply to this email directly or view it on GitHub
#353 (comment).

@justbur

This comment has been minimized.

Show comment
Hide comment
@justbur

justbur Feb 17, 2016

Contributor

I received an email saying that my CA is complete.

Contributor

justbur commented Feb 17, 2016

I received an email saying that my CA is complete.

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Feb 17, 2016

Owner

Great! Welcome to the club:)

Which email did you use? Because I don't see justin@burkett.cc show up in copyright.list yet. The file's last change time stamp is Feb 17, 9:00.

Owner

abo-abo commented Feb 17, 2016

Great! Welcome to the club:)

Which email did you use? Because I don't see justin@burkett.cc show up in copyright.list yet. The file's last change time stamp is Feb 17, 9:00.

@justbur

This comment has been minimized.

Show comment
Hide comment
@justbur

justbur Feb 17, 2016

Contributor

Thanks :)

That's the right address. I haven't received my "fully executed PDF" yet, so maybe that's the problem? Let me check.

Contributor

justbur commented Feb 17, 2016

Thanks :)

That's the right address. I haven't received my "fully executed PDF" yet, so maybe that's the problem? Let me check.

@justbur

This comment has been minimized.

Show comment
Hide comment
@justbur

justbur Feb 24, 2016

Contributor

I heard back from the FSF, and apparently everything should be in order now.

Contributor

justbur commented Feb 24, 2016

I heard back from the FSF, and apparently everything should be in order now.

@abo-abo abo-abo closed this in 1c04fb8 Feb 24, 2016

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Feb 24, 2016

Owner

Yes, I see you on copyright.list now. The change is merged. Looking forward for more good stuff:)

Owner

abo-abo commented Feb 24, 2016

Yes, I see you on copyright.list now. The change is merged. Looking forward for more good stuff:)

@justbur justbur deleted the justbur:fixed-height-mini-option branch Mar 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment